Conversation
filippofontana
force-pushed
the
aia-ipi-fix
branch
3 times, most recently
from
7014857 to
7abfa9c
Compare
josecm
approved these changes
Nov 17, 2025
josecm
requested changes
Nov 17, 2025
Member
josecm
left a comment
josecm
left a comment
There was a problem hiding this comment.
@filippofontana we have updated the internal IPI API and the ipi_id parameter not longer exists. I have rebased and fixed and the issue and placed it here. However, I don't have permissions over the fork's branch to do it. If you can please either add the “Allow edits from maintainers” to the branch in the fork, or update the fork's branch with the changes on the fix I've point to.
Thanks, and sorry for the (huge) delay
Signed-off-by: Filippo Fontana <filippo.fontana@minervasys.tech>
filippofontana
force-pushed
the
aia-ipi-fix
branch
from
7abfa9c to
a2bf9f6
Compare
Contributor
Author
|
@josecm I should have integrated the additional changes. EDIT: spoke too soon, I guess I have to add the header file which defines |
filippofontana
commented
Nov 17, 2025
When using IMSIC, IPIs are sent through direct MSI write in the interrupt file of the target hart. The path through OpenSBI (sbi_send_ipi) is not suitable since SUPERVISOR SOFTWARE INTERRUPTS (SSI) are not enabled in this scenario. By using the generic irqc_send_ipi() function, the IPI sending process is handled correctly in all the possible configurations (PLIC, APLIC, IMSIC). Signed-off-by: Filippo Fontana <filippo.fontana@minervasys.tech> Signed-off-by: Jose Martins <josemartins90@gmail.com>
filippofontana
force-pushed
the
aia-ipi-fix
branch
from
a2bf9f6 to
c72d901
Compare
josecm
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits adds back a change (generic irqc function for sending IPIs in RISC-V) which probably got lost during the integration of AIA inside the main codebase.